Skip to content

fixed caching_mode='unlimited' - #778

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:fix_caching_mode
Feb 23, 2020
Merged

dwhswenson merged 1 commit into
openpathsampling:masterfrom
hejung:fix_caching_mode

Conversation

@hejung

@hejung hejung commented Jun 14, 2018 •

Copy link
Copy Markdown
Contributor

See also the corresponding Issue #779 .

(Maintainer edit: closes #779)

@jhprinz

jhprinz commented Jun 19, 2018

Copy link
Copy Markdown
Contributor

@hejung @dwhswenson I think this can be merged. Obvious typo. Thanks for fixing it.

@jhprinz
jhprinz self-requested a review June 19, 2018 18:13

@jhprinz jhprinz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead

@dwhswenson

Copy link
Copy Markdown
Member

Please note that we have changed to the OPS license from LGPL (2.1 or later) to MIT. For any pull request to OPS that was started while the license was still LGPL, I need an explicit confirmation that you approve of the license change. Please add a comment with something like "The changes in this pull request are licensed under the MIT license."

@hejung

hejung commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

The changes in this pull request are licensed under the MIT license.

@dwhswenson

Copy link
Copy Markdown
Member

@hejung : Could you do a rebase or merge our current master into this branch? I tried to re-run the CI just to be sure that it still worked (I mean, there's no way this would break anything, but always be safe). It appears re-running the build uses the .travis.yml from the original build. Our .travis.yml has changed since then, and the repo isn't compatible with the old Travis script. Thanks!

@dwhswenson dwhswenson removed the onhold label Jul 25, 2019
@hejung

hejung commented Feb 23, 2020

Copy link
Copy Markdown
Contributor Author

Done. Sorry for the delay.

@dwhswenson dwhswenson added the bugfix PRs fixing bugs label Feb 23, 2020
@dwhswenson
dwhswenson merged commit 991564d into openpathsampling:master Feb 23, 2020
@dwhswenson

Copy link
Copy Markdown
Member

Thanks! Merging this.

@hejung
hejung deleted the fix_caching_mode branch February 25, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PRs fixing bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: caching_mode='unlimited' does not work

3 participants