Repository navigation
Improvements on progress output - #676
Conversation
Generalizes and improves (for readability) the output. Also includes some additional logging in ensemble.py (for the trajectory-building stuff)
|
This also added some additional logging to |
|
Now that #681 is in, this passes! Ready for review. The |
|
Lookgs good to me. The formatting seems to be a lot of code, but I don't know a better solution. Will merge now. |
I'm pretty sure there is a better solution, but it would involve a complete rewrite. The problem was that my first version forgot about rounding up, so I kinda had to hack that in. Something to rewrite someday; lots of other things much higher on the priority list! |
This PR fixes a few minor annoyances with the progress output during a path sampling simulation. In particular, it includes the following:
paths.tools, so that it can be re-used by other objects. Just needs the time elapsed, the steps completed, and the total number of stepsNew output looks something like this:
The time elapsed is always the full string (
1 day 2 hours 3 minutes 4 seconds). The time remaining always contains the first two (occupied) "levels" (day, hour, minute, second) with the remainder to 2 decimal places in the last. So (1 day 2.05 hours, or as above,5 hours 2.52 minutes). I thought this would be the most readable (and it acknowledges that the time elapsed is exact, whereas the time remaining is a rough estimate).