Repository navigation
Fix ensemble testing - #242
Merged
Merged
Conversation
Contributor
|
great. Will merge |
dwhswenson
added a commit
to dwhswenson/openpathsampling
that referenced
this pull request
May 3, 2015
Now all test trajs in testensemble are passed through make_1d_traj. Before, we added this on the trajs for BackwardPrepended tests. Advanced in openpathsampling#242 make that redundant.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd recently been getting occasional errors in
test_ensemble. This PR fixes that.In a test before this fix, I got errors 12/100 runs of
nosetests test_ensemble.py. After this fix, 0/100.The problem was in the way the test trajectories were built. For simplicity, early on I made test trajectories as lists of numbers instead of lists of snapshots. However, this created problems in certain parts of the code, because two "snapshots" in this fake trajectory list could have the same value, and the caching behavior assumes that snapshots never repeat in the trajectory.
The change makes the tests run a little slower (getting an order parameter from a snapshot is more expensive than reading a number from a list of them), but at least it's correct and tests pass consistently!
Anyway, this should fix the problem, and can be merged as soon as it passes tests.