Skip to content

Update Python version in test-openmm-rc - #1149

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:update-python-test-openmm-rc
Jul 4, 2024
Merged

dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:update-python-test-openmm-rc

Conversation

@dwhswenson

Copy link
Copy Markdown
Member

Our script to test OpenMM RCs was pinned to Python 3.9, which we no longer support. Looks like there's another OpenMM RC out, so it is time to update this!!

@dwhswenson

Copy link
Copy Markdown
Member Author

This is ready for review and comment. Without review, I will merge this after at least 8 hours, no sooner than Thu 04 Jul 22:00 GMT (18:00 my local).

(Short merge window because this is a trivial change and I'd like to get this in so that the next regular RC test runs in time to catch any issues.)

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dwhswenson

Copy link
Copy Markdown
Member Author

Thanks for the quick review! Merging.

@dwhswenson
dwhswenson merged commit 4e90f68 into openpathsampling:master Jul 4, 2024
@dwhswenson
dwhswenson deleted the update-python-test-openmm-rc branch July 4, 2024 14:01
@sroet

sroet commented Jul 4, 2024

Copy link
Copy Markdown
Member

Thanks for the quick review! Merging.

You caught me when I didn't have anything to do on a train

@dwhswenson dwhswenson mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants