Skip to content

Temporary pin: numpy<1.24 - #1126

Merged
dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:pin-numpy
Dec 26, 2022
Merged

dwhswenson merged 1 commit into
openpathsampling:masterfrom
dwhswenson:pin-numpy

Conversation

@dwhswenson

@dwhswenson dwhswenson commented Dec 26, 2022 •

Copy link
Copy Markdown
Member

Looks like recent failures in CI are because of a numpy/numba incompatibility. See numba/numba#8615. Should be fixed soon, but hopefully this pin will fix for now.

Resolves #1125.

@sroet sroet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a temporary fix. Feel free to merge once CI passes

@codecov

codecov Bot commented Dec 26, 2022 •

Copy link
Copy Markdown

Codecov Report

Base: 81.76% // Head: 81.75% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (02102f3) compared to base (609260a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   81.76%   81.75%   -0.01%     
==========================================
  Files         142      142              
  Lines       15612    15612              
==========================================
- Hits        12765    12764       -1     
- Misses       2847     2848       +1     
Impacted Files Coverage Δ
openpathsampling/netcdfplus/cache.py 63.72% <0.00%> (-0.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dwhswenson
dwhswenson merged commit aecf8a6 into openpathsampling:master Dec 26, 2022
@dwhswenson
dwhswenson deleted the pin-numpy branch December 26, 2022 14:10
dwhswenson added a commit to dwhswenson/ops_tutorial that referenced this pull request Jan 7, 2023
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failures (due to llvm change?)

2 participants