Skip to content

[WIP] Fail fast if prepare fails in external engines #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dwhswenson wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] Fail fast if prepare fails in external engines #1118

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
accdcba
Fail fast if `prepare` fails in external engines
dwhswenson Aug 8, 2022
d59bb76
add error code to default prepare
dwhswenson Aug 8, 2022
d384179
fix direction of logic
dwhswenson Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add error code to default prepare
  • Loading branch information
@dwhswenson
dwhswenson committed Aug 8, 2022
commit d59bb7609ea470171134ae03e729210e7f20a046
7 changes: 6 additions & 1 deletion openpathsampling/engines/external_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,8 +314,13 @@ def who_to_kill(self):
def prepare(self):
"""
Any preparation between writing snapshot and running command

Returns
-------
int :
Error code. Return 0 on success, nonzero on any error.
"""
pass
return 0

def cleanup(self):
"""Any cleanup actions to do after the subprocess dies."""
Expand Down