Skip to content

Update standard filename setter for external engines in OPS 2.0 - #1103

Open
sroet wants to merge 8 commits into
openpathsampling:dev-2.0from
sroet:issue_1101_2x_default
Open

Update standard filename setter for external engines in OPS 2.0#1103
sroet wants to merge 8 commits into
openpathsampling:dev-2.0from
sroet:issue_1101_2x_default

Conversation

@sroet

@sroet sroet commented Jan 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

This does a couple things:

  • cherry-picks in Add FutureWarning for default filesetter external engines #1102
  • the default filename_setter for ExternalEngines are now RandomStringFilenames instead of FilenameSetter
  • FilenameSetter is now a subclass of RandomStringFilenames (instead of the other way around) (this was needed to still be able to use Filename setter after changing the default options)
  • FilenameSetter now returns a string that is padded up to self.length` with zeroes
  • GromacsEngine.set_filenames only resets the filename_setter if the filename_setter has a reset attribute
  • updated the tests for this behaviout
  • solved pep8 complaints on all touched files
  • dropped nose from all touched tests

part of the discussion on #1101

@sroet sroet changed the title Update standard filenamesetter for OPS 2.0 Update standard filename setter for external engines in OPS 2.0 Jan 27, 2022
@sroet
sroet requested a review from dwhswenson January 27, 2022 18:55
@sroet

sroet commented Jan 28, 2022

Copy link
Copy Markdown
Member Author

failing CI is due know issue with importing openmm (or openmmtools) in notebooks is raising a warning:

Traceback:
Unexpected output fields from running code: {'stderr'}

@dwhswenson dwhswenson added the 2.0 issues and PRs for the 2.0 release label Jan 29, 2022
@sroet

sroet commented Feb 3, 2022

Copy link
Copy Markdown
Member Author

@dwhswenson all green, this is ready for review

@sroet sroet mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dwhswenson dwhswenson Awaiting requested review from dwhswenson

Assignees

No one assigned

Labels

2.0 issues and PRs for the 2.0 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sroet @dwhswenson