Repository navigation
SimStore: Fix storable function serialization - #1088
Merged
dwhswenson merged 2 commits intoNov 8, 2021
Merged
dwhswenson merged 2 commits into
dwhswenson merged 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
=======================================
Coverage 81.56% 81.56%
=======================================
Files 140 140
Lines 15452 15452
=======================================
Hits 12604 12604
Misses 2848 2848 Continue to review full report at Codecov.
|
Member
Author
|
This is ready for review and comment. I will leave it open for at least 24 hours, merging no earlier than Mon 08 Nov 14:00 GMT (09:00 my local). |
sroet
approved these changes
Nov 8, 2021
sroet
left a comment
sroet
left a comment
Member
There was a problem hiding this comment.
1 indentation suggestion, feel free to ignore. LGTM otherwise
Co-authored-by: Sander Roet <sanderroet@hotmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in SimStore storable functions serialization. When support for function periodicity was added in #990, it looks like I failed to add the periodicity information to the
StorableFunction.to_dict. This fixes that, and includes a test to prevent regression.Currently, function periodicity is only used by the (as yet unreleased) command line tools for setting up a simulation, where it is only used at object creation time to determine whether a volume should be periodic or not. This means that the only use case where this bug could be a problem would be if the user is using the unreleased CLI
wizardto create new volumes for periodic CVs after loading that CV from a file. This is an unlikely use case, so I don't think this is a critical concern, but it does push for an OPS release before the CLI wizard is released.