Skip to content

New path tree #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwhswenson merged 18 commits into from
Aug 31, 2024
Merged

New path tree #1048

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
021ec99
Start to new path trees
dwhswenson Aug 12, 2021
990dc9b
fix path tree for two-way TPS connectors
dwhswenson Aug 23, 2021
04bef1d
Merge branch 'master' of github.com:openpathsampling/openpathsampling…
dwhswenson Apr 30, 2024
95f1aa0
First implementation of the SVG renderer
dwhswenson May 1, 2024
571f497
maybe convert separate plotters into subclasses?
dwhswenson May 5, 2024
95c2e30
refactor of new plotters
dwhswenson Jul 13, 2024
6d6c1af
more updates to refactor new path trees
dwhswenson Jul 17, 2024
16d26b8
Merge branch 'master' of github.com:openpathsampling/openpathsampling…
dwhswenson Jul 18, 2024
7ad1881
minor docs update
dwhswenson Aug 12, 2024
f473daf
Merge remote-tracking branch 'upstream/master' into new_path_tree
dwhswenson Aug 13, 2024
88b2f9a
Merge remote-tracking branch 'upstream/master' into new_path_tree
dwhswenson Aug 13, 2024
64aad6d
fix up some plotting errors
dwhswenson Aug 27, 2024
c7029b6
Update openpathsampling/experimental/path_tree/path_tree.py
dwhswenson Aug 30, 2024
16ede3b
remove commented code; use .plot method
dwhswenson Aug 30, 2024
16c2a89
fix typo in make_layout_blocks; warn non-use
dwhswenson Aug 30, 2024
dc67ad4
remove refactored code
dwhswenson Aug 30, 2024
3622d00
Update openpathsampling/experimental/path_tree/options.py
dwhswenson Aug 30, 2024
f4b714f
remove incorrect docstring
dwhswenson Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove commented code; use .plot method
  • Loading branch information
@dwhswenson
dwhswenson committed Aug 30, 2024
commit 16ede3b5a486af0fff482dbb7f92382a90f23f57
2 changes: 1 addition & 1 deletion openpathsampling/experimental/path_tree/path_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,6 @@ def matplotlib(self, plotter=None):
plotter = plotter()

ax = plotter.ax
plotter.draw_trajectories(self.path_tree_steps)
plotter.draw(self)

return ax.figure
8 changes: 0 additions & 8 deletions openpathsampling/experimental/path_tree/svg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ def _reset(self):
self.min_x = float("inf")
self.max_x = float("-inf")

# @staticmethod
# def step_basics(step, options):
# mover = canonicalize_mover(step.mover)
# mover_options = options.movers[mover]
# color = mover_options.color
# plot_segments = mover_options.get_left_right(step)
# return mover, color, plot_segments

def draw_trajectory(self, row, step):
plot_segments, color = self.get_step_plot_details(step)
for left, right in plot_segments:
Expand Down