Skip to content

Overlaps - #25

Merged
paulromano merged 9 commits into
openmc-dev:masterfrom
pshriwise:overlap
Jun 18, 2019
Merged

paulromano merged 9 commits into
openmc-dev:masterfrom
pshriwise:overlap

Conversation

@pshriwise

Copy link
Copy Markdown
Collaborator

This adds plotting along with a customizable color in the same way that the background color is customized. Overlap plotting can be turned on/off with the Ctrl+P shortcut.

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to use this, I get the following traceback:

Traceback (most recent call last):
  File "/home/romano/openmc-plotter/openmc-plotter", line 938, in <module>
    mainWindow.loadGui()
  File "/home/romano/openmc-plotter/openmc-plotter", line 92, in loadGui
    self.colorDialog.updateDialogValues()
  File "/home/romano/openmc-plotter/plotgui.py", line 1015, in updateDialogValues
    self.updateOverlapColor()
  File "/home/romano/openmc-plotter/plotgui.py", line 1075, in updateOverlapColor
    color = self.model.activeView.overlap_color
AttributeError: 'PlotView' object has no attribute 'overlap_color'

I made sure to use the latest develop branch of OpenMC, so that shouldn't be the issue.

Comment thread plotmodel.py Outdated
@pshriwise

Copy link
Copy Markdown
Collaborator Author

It's likely this is because there is an out of date plot_settings.pkl file in the model directory. We check the version number when loading plot views but not when starting up the GUI. I've added a check for that now, so it should ignore those settings an generate the default view.

@paulromano

Copy link
Copy Markdown
Contributor

Ah, ok, that makes sense. Now it works!

@paulromano
paulromano merged commit ad007c7 into openmc-dev:master Jun 18, 2019
@pshriwise
pshriwise deleted the overlap branch July 9, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants