Repository navigation
SpatialBox can be constructed via ctor with parameters - #3760
Conversation
|
What is the intended use case for this PR? |
We have a C++ code that is build around openmc. The code needs to construct For example, |
|
Makes sense to me! I'm a fan of using the C++ API in other applications, though we have some work to do to make that easier in the future. If this suits your needs, sounds good to me! I know this is a pretty trivial constructor, but as a matter of practice would you be willing to add a quick C++ test @andrsd so we're exercising it regularly? Otherwise maybe @GuySten or I could tag one on for you? |
I think I can build a simple unit test for this. I will ping you guys if I need any help...
Glad to hear that! I think our ongoing efforts will test the C++ API this way. There might be more patches like this one in future as we progress. |
|
o7 |
Description
SpatialBoxcan be constructed from a C++ code via a constructor that takeslower_left,upper_right, andfissionparameters. Before this change,SpatialBoxwas constructible only by supplying an XML node.Checklist