Repository navigation
Fix for plotting model with multi-group cross sections - #3748
Conversation
paulromano
left a comment
There was a problem hiding this comment.
Thanks @GuySten. I ended up removing all the extra code related to cross_sections. The recommended way to handle the data is to set openmc.config['mg_cross_sections'] before calling the plot() method. I'll comment on the original issue too.
|
There were a few problems:
|
There was a problem hiding this comment.
Sorry about the mishaps in my updates. I did make another change to simplify the additions to Model.plot. The reason that the relative path didn't work in the test is because for testing we set openmc.config['resolve_paths'] = False, so the relative path is kept. However, the default configuration for users is openmc.config['resolve_paths'] = True which means that it should work out of the box for users. Instead of introducing config.patch in Model.plot, I changed it so that we set the absolute path in the test. Let me know if you're OK with this now and if so, we're good to merge.
|
Now we are good to merge. |
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Description
openmc crash when trying to plot a model with multigroup cross sections.
This PR fix that.
Fixes #3747
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)