Repository navigation
Simplify rectangular lattice crossing and correctly handle corner checks - #3703
Conversation
lower mesh resolution
GuySten
changed the title
|
@pshriwise, could you take some time to review this PR? |
Happy to. I was staring at it a bit this morning already in fact. |
paulromano
left a comment
paulromano
left a comment
There was a problem hiding this comment.
Just made two updates here:
- Added another guard against direction components being zero when setting
lattice_trans - Cleaned up the model in the test
Good to go as far as I'm concerned! @pshriwise do you want to review before we merge?
Nope! The two changes you noted to account for direction components that are zero are in and it seems the tests pass with the lost particle setting removed in the model -- the only other change I was going to suggest. |
|
This is awesome; I'm delighted to see this resolved! |
…cks (openmc-dev#3703) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
…cks (openmc-dev#3703) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
5 participants
Description
This PR simplify rectangular lattice crossing algorithm and add support for corner crossing.
The test case was taken from #2445 with lower resolution like #3355.
Fixes #3355 and fixes #2445.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)