Repository navigation
Fix typo in DAGMC lost particle test - #3634
Merged
paulromano merged 2 commits intoNov 14, 2025
Merged
Conversation
pshriwise
changed the title
paulromano
reviewed
Nov 14, 2025
|
|
||
|
|
||
| def test_lost_particles(run_in_tmpdir, broken_dagmc_model): | ||
| def test_lost_particles(broken_dagmc_model): |
Contributor
There was a problem hiding this comment.
Why was run_in_tmpdir removed here?
Contributor
Author
There was a problem hiding this comment.
Wanted the model.xml when I was testing locally and forgot to re-add it. My bad!
paulromano
approved these changes
Nov 14, 2025
paulromano
enabled auto-merge (squash)
November 14, 2025 03:37
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a typo in the DAGMC lost particle test caught by @paulromano.
This was causing the first case (in which lost particles should be reported when the DAGMC universe is used to fill a CSG cell) to be executed twice.
This fix ensures that the case where the DAGMC universe is used as the root universe is also checked.
A comment was also expanded to better explain the intent of the test.
Checklist
I have run [clang-format](https://docs.openmc.org/en/latest/devguide/styleguide.html#automatic-formatting) (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)