Repository navigation
Support MPI parallelism in R2SManager - #3632
Merged
Merged
Conversation
pshriwise
requested changes
Nov 18, 2025
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Some small suggestions mainly for clarity here, @paulromano, but it looks nice! Thanks for addressing this!
Contributor
Author
|
@pshriwise thanks for your review! comments have been addressed |
pshriwise
approved these changes
Nov 18, 2025
Contributor
There was a problem hiding this comment.
Thanks @paulromano! I'll give this a short 24h cooldown in case anyone else wants to have a look.
5 tasks done
5 tasks done
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes changes in the
R2SManagerand related classes in order to work properly with MPI parallelism. The changes include:mpiexec ... openmcbecause nestedmpiexeccalls are are not supported.TemporarySessioncontext manager was also updated to work when called in parallelChecklist
I have run clang-format (version 15) on any C++ source files (if applicable)