Repository navigation
Allow Path objects in MGXSLibrary.export_to_hdf5 - #3608
Merged
paulromano merged 3 commits intoOct 20, 2025
Merged
paulromano merged 3 commits into
paulromano merged 3 commits into
Conversation
paulromano
changed the title
paulromano
enabled auto-merge (squash)
October 20, 2025 14:40
Grego01-biot
pushed a commit
to Grego01-biot/openmc
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have got quite use to passing around a
Pathinstead of strings for a filepath. I tried to save a mgxs file using a Path today and got a type error so I thought it would be nice if this function allowed Paths to be put in as well as strings (like we do in most other places in the code).Fixes # (issue)
Checklist