Skip to content

Enable specifying reference direction for azimuthal angle in PolarAzimuthal distribution #3582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuySten merged 13 commits into from
Nov 3, 2025
Merged

Enable specifying reference direction for azimuthal angle in PolarAzimuthal distribution #3582

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
09143db
save reference direction for azimutal angle
GuySten Sep 25, 2025
ad8a276
ran clang format
GuySten Sep 25, 2025
717c4d9
revert ran clang format on python file
GuySten Sep 25, 2025
fe7a80e
bugfix
GuySten Sep 25, 2025
12d1816
bugfix
GuySten Sep 25, 2025
85b5d3c
update input
GuySten Sep 25, 2025
51fffc5
fix regression test
GuySten Sep 25, 2025
82c4ac6
add case for mu=-1 that change regression
GuySten Sep 25, 2025
ff7aeea
ran clang format
GuySten Sep 25, 2025
e35cc7d
Merge branch 'openmc-dev:develop' into polar-fix
GuySten Oct 16, 2025
c10a674
added ref vwu tests
shimwell Oct 31, 2025
5f2e60e
Merge pull request #33 from shimwell/polar-fix-tests
GuySten Nov 1, 2025
b242c32
fixed checks in PolarAzimuthal
GuySten Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix regression test
  • Loading branch information
@GuySten
GuySten committed Sep 25, 2025
commit 51fffc5bc6cf8301fd9dda018bcc9c937aedd7c6
2 changes: 0 additions & 2 deletions src/distribution_multi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ Direction PolarAzimuthal::sample(uint64_t* seed) const
double mu = mu_->sample(seed);
if (mu == 1.0)
return u_ref_;
if (mu == -1.0)
return -u_ref_;

// Sample azimuthal angle
double phi = phi_->sample(seed);
Expand Down
2 changes: 1 addition & 1 deletion tests/regression_tests/source/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
k-combined:
3.080655E-01 4.837707E-03
3.034717E-01 2.799386E-03
Loading