Repository navigation
Remove several TODOs related to C++17 support - #3574
Merged
Merged
Conversation
paulromano
approved these changes
Sep 23, 2025
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @GuySten. I ended up revert the change using the parallel sort because it requires linking against a new library (Intel TBB). If we are going to do that, we should understand all the implications for compatibility. For now, I'll merge the other changes but if we want to consider using parallel algorithms from C++17, we should discuss that over an issue first.
paulromano
changed the title
paulromano
enabled auto-merge (squash)
September 23, 2025 14:05
Grego01-biot
pushed a commit
to Grego01-biot/openmc
that referenced
this pull request
Oct 27, 2025
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that c++17 is supported we can fulfill some TODOs in the code.
tagging @paulromano, because this PR affects performance of event based transport.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)