Repository navigation
Bump up tolerance for flaky activation test - #3560
Merged
Merged
Conversation
GuySten
enabled auto-merge (squash)
September 3, 2025 16:26
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've noticed quite a few random failures in CI lately of one of the cases in
test_activation, where the reaction rate is estimated by tallying a 100-group flux and then collapsing it with cross sections. It is expected that you don't get the exactly right answer because it doesn't account for energy self-shielding within the groups, which is why the test is occasionally failing. This PR bumps up the tolerance for that case which should mitigate the random failures.Checklist