Skip to content

Bump up tolerance for flaky activation test - #3560

Merged
GuySten merged 1 commit into
openmc-dev:developfrom
paulromano:fix-activation-test
Sep 3, 2025
Merged

GuySten merged 1 commit into
openmc-dev:developfrom
paulromano:fix-activation-test

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

Description

I've noticed quite a few random failures in CI lately of one of the cases in test_activation, where the reaction rate is estimated by tallying a 100-group flux and then collapsing it with cross sections. It is expected that you don't get the exactly right answer because it doesn't account for energy self-shielding within the groups, which is why the test is occasionally failing. This PR bumps up the tolerance for that case which should mitigate the random failures.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@GuySten
GuySten enabled auto-merge (squash) September 3, 2025 16:26
@GuySten
GuySten merged commit 5918564 into openmc-dev:develop Sep 3, 2025
18 of 24 checks passed
@paulromano
paulromano deleted the fix-activation-test branch September 5, 2025 21:54
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants