Skip to content

Introduce SlicePlot and VoxelPlot to replace the Plot class #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 13 commits into from
Dec 5, 2025
Merged

Introduce SlicePlot and VoxelPlot to replace the Plot class #3528

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6979b4b
Add stat:sum field to MCPL files for proper weight normalization (#3514)
bpolania Aug 6, 2025
aa39d63
feat: split Plot class into SlicePlot and VoxelPlot
bpolania Aug 11, 2025
64d72b0
fix: enforce strict width/pixels validation for plot classes
bpolania Aug 11, 2025
3ffb2f4
test: update tests to use new SlicePlot and VoxelPlot classes
bpolania Aug 11, 2025
4574244
test: add comprehensive tests for SlicePlot and VoxelPlot classes
bpolania Aug 11, 2025
4517b98
Merge upstream/develop into feature/split-plot-classes
bpolania Aug 11, 2025
ed24df1
Fix Plot.from_geometry to avoid deprecation warning when used as clas…
bpolania Aug 12, 2025
cb1169d
Fix C++ formatting in mcpl_interface.cpp
bpolania Aug 12, 2025
cb7e171
Remove to_ipython_image from VoxelPlot
paulromano Dec 4, 2025
a49ec1e
Simplify backward compatibility
paulromano Dec 4, 2025
f3e3f32
Update use of Plot throughout codebase
paulromano Dec 5, 2025
e5aba79
Merge branch 'develop' into pr/bpolania/3528
paulromano Dec 5, 2025
49b3bd1
Fix conflicting mcpl_hdr_add_data_fpt definitions
paulromano Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: split Plot class into SlicePlot and VoxelPlot 
This refactoring improves the plot interface by:
- Creating dedicated SlicePlot class for 2D slice plots
- Creating dedicated VoxelPlot class for 3D voxel plots
- Maintaining backward compatibility with deprecated Plot class
- Properly separating attributes specific to each plot type

The width attribute now accepts 2 values for slice plots and 3 for voxel plots.
The basis attribute only exists on SlicePlot as it doesn't apply to voxel plots.

Addresses #3507
  • Loading branch information
@bpolania
bpolania committed Aug 11, 2025
commit aa39d63d3a535758b094546d70c32282593dc4c6
Loading