Repository navigation
Add flag to CMakeLists to use submodules instead of searching - #3480
Merged
Merged
Conversation
paulromano
approved these changes
Jul 3, 2025
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR @nglaser3! I updated the name of the option to OPENMC_FORCE_VENDORED_LIBS but otherwise looks good.
paulromano
enabled auto-merge (squash)
July 3, 2025 12:55
ahnaf-tahmid-chowdhury
pushed a commit
to ahnaf-tahmid-chowdhury/OpenMC
that referenced
this pull request
Jul 7, 2025
…-dev#3480) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…-dev#3480) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a flag to the
CMakeLists.txtto force OpenMC to use the submodules invendor/as opposed to search the user's system for the submodules. The search causes problems when building Cardinal (see this discussion post), which are fixed when forcing OpenMC to use the submodules invendor/.This flag is default off, and does not change the existing default behavior when building.
@aprilnovak
Checklist