Repository navigation
Support arbitrary symmetry axis for CylindricalIndependent class - #3474
Merged
Merged
Conversation
GuySten
changed the title
GuySten
force-pushed
the
cylindrical_independent
branch
from
August 27, 2025 19:59
e9cd2e4 to
76508f8
Compare
GuySten
changed the title
paulromano
changed the title
paulromano
approved these changes
Feb 21, 2026
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
@GuySten Thanks a lot for this enhancement. I made a few updates:
- Fixed minor issues in the implementation and extended tests
- Removed
ring_unformand just made it a special case incylindrical_uniformforheight=0 - Pass extra arguments in
cylindrical_uniformas**kwargsin case there are future changes toCylindricalIndependent
paulromano
enabled auto-merge (squash)
February 21, 2026 18:05
jon-proximafusion
pushed a commit
to shimwell/openmc
that referenced
this pull request
Apr 13, 2026
…nmc-dev#3474) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…nmc-dev#3474) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR generalize CylindricalIndependent to support symmetry axis in every direction and not only in z direction.
This PR also implement cylindrical_uniform and ring_uniform to generate uniform spatial distributions over cylinders and rings in a similar way to spherical_uniform.
Checklist