Repository navigation
Enabling MCPL source files to be read when using surf_source_read - #3472
Merged
paulromano merged 4 commits intoJul 18, 2025
Merged
Conversation
paulromano
approved these changes
Jul 18, 2025
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @JoffreyDorville!
paulromano
enabled auto-merge (squash)
July 18, 2025 06:33
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…enmc-dev#3472) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
surf_source_readfrom the settings with MCPL files, OpenMC fails and complains about not being able to read it as a HDF5 file. One easy way to avoid this error was to use aopenmc.FileSourceobject and pass it as asettings.sourceinstead.This PR enables source files in MCPL format to be read when using
surf_source_read.Checklist