Skip to content

Fix Dockerfile DAGMC build - #3463

Merged
shimwell merged 1 commit into
openmc-dev:developfrom
paulromano:dockerfile-dagmc-fix
Jun 24, 2025
Merged

shimwell merged 1 commit into
openmc-dev:developfrom
paulromano:dockerfile-dagmc-fix

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

Description

After #3442 was merged, our Docker builds started working again but the DAGMC option is still broken. The explanation is as follows: the MOAB → PyMOAB step of the DAGMC tool-chain aborts during its CMake configure phase because the Python virtual-environment that the Dockerfile creates is missing setuptools (and therefore also has no Cython).
The relevant lines in the log are:

ModuleNotFoundError: No module named 'setuptools'
...
CMake Error at pymoab/CMakeLists.txt:26 (MESSAGE): Python setuptools module is missing. 

Because the find_package(Cython) call follows immediately after this test, CMake then also reports that Cython cannot be found, so configuration terminates and the entire job fails.

The fix here is to make sure that setuptools and Cython are installed in the virtual environment.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano
paulromano requested a review from shimwell as a code owner June 24, 2025 03:26
@shimwell shimwell self-assigned this Jun 24, 2025
@shimwell

Copy link
Copy Markdown
Member

Thanks Paul, this builds locally for me, as this is a small change I shall go ahead and merge it.

@shimwell
shimwell merged commit 3a8894c into openmc-dev:develop Jun 24, 2025
@paulromano
paulromano deleted the dockerfile-dagmc-fix branch June 24, 2025 15:20
ahnaf-tahmid-chowdhury pushed a commit to ahnaf-tahmid-chowdhury/OpenMC that referenced this pull request Jul 7, 2025
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants