Repository navigation
Fix Dockerfile DAGMC build - #3463
Merged
Merged
Conversation
shimwell
approved these changes
Jun 24, 2025
Member
|
Thanks Paul, this builds locally for me, as this is a small change I shall go ahead and merge it. |
ahnaf-tahmid-chowdhury
pushed a commit
to ahnaf-tahmid-chowdhury/OpenMC
that referenced
this pull request
Jul 7, 2025
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #3442 was merged, our Docker builds started working again but the DAGMC option is still broken. The explanation is as follows: the MOAB → PyMOAB step of the DAGMC tool-chain aborts during its CMake configure phase because the Python virtual-environment that the Dockerfile creates is missing
setuptools(and therefore also has no Cython).The relevant lines in the log are:
Because the
find_package(Cython)call follows immediately after this test, CMake then also reports that Cython cannot be found, so configuration terminates and the entire job fails.The fix here is to make sure that setuptools and Cython are installed in the virtual environment.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)