Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
dddb144
Implementation of VOV
Greg-biot Nov 21, 2024
0bed61c
Delete src/tallies/tally (1).cpp:Zone.Identifier
Grego01-biot Nov 21, 2024
0406fa5
Delete src/tallies/tally_scoring (1).cpp:Zone.Identifier
Grego01-biot Nov 21, 2024
4aea85e
Modification on VOV formula
Greg-biot Nov 21, 2024
e046bac
Merge between origin and origin/stat_testing
Greg-biot Nov 21, 2024
5a44b61
Modifications of VOV + implementation of FOM
Greg-biot Dec 6, 2024
44763f5
Settings setup + FOM implementation
Greg-biot Dec 11, 2024
7708c4a
VOV for each tally bin implemented without error, ready for testing
Greg-biot Dec 11, 2024
6cc8b0d
Settings modifications + VOV modifications
Greg-biot Dec 18, 2024
bb56602
Merge remote-tracking branch 'upstream/develop' into stat_testing
Greg-biot Dec 18, 2024
66b3c4e
Tally optional VOV attribute
Greg-biot Dec 18, 2024
10d484c
New implementation of VOV + FOM
Greg-biot Jan 16, 2025
bc77d69
To stay up to date
Greg-biot Jan 16, 2025
fb4cdb0
Latest update of VOV and FOM
Greg-biot Feb 4, 2025
ec3eedd
Merge branch 'openmc-dev:develop' into stat_testing
Grego01-biot Feb 4, 2025
7cbf0a9
Missing files for FOM
Greg-biot Feb 4, 2025
dd5b6ae
New FOM and VOV
Feb 14, 2025
f905f0e
VOV implemented in Python API and C++
Feb 15, 2025
980961b
Merge remote-tracking branch 'upstream/develop' into vov_testing
Feb 19, 2025
8cd609d
Merging conflicts
Mar 27, 2025
6c9a608
VOV modifications
Mar 27, 2025
fbd173f
Removal of unnecessary elements for VOV implementation
Mar 27, 2025
4e236bc
test_tallies modified for VOV
Mar 28, 2025
5a6de69
Merge remote-tracking branch 'upstream/develop' into vov_testing
Apr 10, 2025
c94a83e
Python API modifications + addition of VOV flag
Apr 10, 2025
31c4bba
Deleting spaces
Apr 10, 2025
b1ecb55
Normality test and VOV test
Apr 12, 2025
9029b76
Merge remote-tracking branch 'upstream/develop' into vov_testing
Apr 15, 2025
3802484
new modifications for VOV and higher moments tests
Jun 11, 2025
af592d2
solving merging conflicts
Jun 11, 2025
58bf576
New tests for VOV and normality tests
Jun 17, 2025
96be75c
Merge remote-tracking branch 'upstream/develop' into vov_testing
Jun 17, 2025
2a038c7
Merge remote-tracking branch 'upstream/develop' into vov_testing
Aug 12, 2025
5179b45
Modifying the tally.cpp
Aug 18, 2025
0810f29
merging with upstream/develop
Aug 18, 2025
45ee452
New tests and modification of the VOV property
Aug 18, 2025
9be39c3
clang-format
Aug 18, 2025
f0e32be
New tests
Aug 19, 2025
ab8f2a1
matplotlib error
Aug 19, 2025
26b9a6d
New modifications for OpenMC tests
Aug 19, 2025
5411fb6
WW FW cadis mesh tests not passing
Aug 20, 2025
eab7bcb
Merge remote-tracking branch 'upstream/develop' into vov_testing
Aug 20, 2025
1386ffc
All tests passing
Aug 20, 2025
78a84ff
reduce tally results function modified
Aug 20, 2025
bb85820
Tally results planes allocations
Aug 21, 2025
1f17d14
Modifications due to PR comments
Aug 22, 2025
61e46ed
Update openmc/settings.py
Grego01-biot Aug 22, 2025
637c379
Update include/openmc/hdf5_interface.h
Grego01-biot Aug 22, 2025
4457f0e
Update include/openmc/hdf5_interface.h
Grego01-biot Aug 22, 2025
2e1e170
Update openmc/tallies.py
Grego01-biot Aug 22, 2025
da5ba9d
Update openmc/tallies.py
Grego01-biot Aug 22, 2025
67578ce
Update openmc/tallies.py
Grego01-biot Aug 22, 2025
c8d6a13
Update openmc/statepoint.py
Grego01-biot Aug 22, 2025
be41396
Update openmc/tallies.py
Grego01-biot Aug 22, 2025
9969fe1
Update openmc/tallies.py
Grego01-biot Aug 22, 2025
bc59753
Modifications due to comments
Aug 23, 2025
8bae09d
typo
Aug 23, 2025
627f68b
Updates with new properties for skewness and kurtosis despite the nor…
Grego01-biot Aug 31, 2025
6a63f48
Merge remote-tracking branch 'upstream/develop' into vov_testing
Grego01-biot Aug 31, 2025
6ec77e4
Formatting issue with double quotes
Grego01-biot Sep 2, 2025
bce5c5d
Python formatting and cleaning up the files
Grego01-biot Sep 4, 2025
4a222c7
Format comments and spacing in urr.h
Grego01-biot Sep 4, 2025
738cc42
Fix formatting of comments in urr.h
Grego01-biot Sep 4, 2025
9051093
Fix formatting issue in settings.py
Grego01-biot Sep 4, 2025
f0cd06d
Add newline at end of file in statepoint.py
Grego01-biot Sep 4, 2025
f0be4ce
Delete openmc/tally_stats.py
Grego01-biot Sep 4, 2025
c427966
Refactor test_stats.py for consistency and readability
Grego01-biot Sep 4, 2025
b254189
Resolve modify/delete for tally_stats.py during rebase
Grego01-biot Sep 5, 2025
da629ff
Deleting modifications in test_stats.py
Grego01-biot Sep 5, 2025
94ab834
Upstream commits
Grego01-biot Sep 5, 2025
dac8a0c
Delete openmc/tally_stats.py
Grego01-biot Sep 5, 2025
6bc3bf7
Delete tests/geometry.xml
Grego01-biot Sep 5, 2025
b4a0164
Delete tests/model.xml
Grego01-biot Sep 5, 2025
c2a13f0
Delete tests/regression_tests/source_dlopen/CMakeLists.txt
Grego01-biot Sep 5, 2025
ee55f4c
Delete tests/regression_tests/source_parameterized_dlopen/CMakeLists.txt
Grego01-biot Sep 5, 2025
90d1a92
Add newline at end of settings.py
Grego01-biot Sep 5, 2025
ae0b5fd
Fix indentation in return statement
Grego01-biot Sep 5, 2025
5f81e20
Fix missing newline at end of settings.py
Grego01-biot Sep 5, 2025
bbb568f
Clean up return statement in settings.py
Grego01-biot Sep 5, 2025
dabe583
Fix formatting by removing unnecessary whitespace
Grego01-biot Sep 5, 2025
a319c8b
Update test_stats.py
Grego01-biot Sep 5, 2025
58ea0bb
Update test_tallies.py
Grego01-biot Sep 5, 2025
178a31c
Documentation added to tallies.rst
Grego01-biot Sep 5, 2025
4fb5cd6
Merging upstream commit
Grego01-biot Sep 5, 2025
3129e27
depletion: fix performance of chain matrix construction (#3567)
rwcarlsen Sep 11, 2025
5d5eacd
PowerLaw raises an error if sampling interval contains negative value…
j-fletcher Sep 11, 2025
4f1b8ad
Fixed a bug when combining TimeFilter, MeshFilter, and tracklength es…
GuySten Sep 12, 2025
f336385
Merge remote-tracking branch 'upstream/develop' into vov_testing
Sep 16, 2025
63de263
Small updates in documentation, style
paulromano Oct 16, 2025
b695db8
Make m2, m3, m4 properties
paulromano Oct 17, 2025
6e36557
Make skew and kurtosis methods on Tally and adopt scipy conventions
paulromano Oct 18, 2025
9ecdc6f
Remove unused variance_of_variance function
paulromano Oct 18, 2025
1c79af4
Add missing update to statepoint.rst
paulromano Oct 18, 2025
d2b801a
Rename vov_enabled to higher_moments
paulromano Oct 18, 2025
61f165e
Don't write VOV in tallies.out
paulromano Oct 18, 2025
5eee478
Small change in figure_or_merit
paulromano Oct 18, 2025
e84c6ca
Merge branch 'develop' into pr/Grego01-biot/3454
paulromano Oct 27, 2025
43a66ce
Solving issues and implementing PR comments
Oct 28, 2025
d37d23d
Small fixes
paulromano Oct 29, 2025
4f43715
Expand docstrings for test methods
paulromano Oct 29, 2025
0de62b2
Change return values of skewtest, kurtosistest, and normaltest
paulromano Oct 29, 2025
be25107
Raise ValueError from sum_third and sum_fourth
paulromano Nov 11, 2025
d73c44d
Fix scipy comparison test
paulromano Nov 11, 2025
08f047b
Remove print_normality_report
paulromano Nov 11, 2025
ed20551
Remove normality_tests
paulromano Nov 11, 2025
0a68862
Use _vov attribute properly
paulromano Nov 11, 2025
8e5abf5
Fix use of sum_third and sum_fourth
paulromano Nov 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
solving merging conflicts
  • Loading branch information
Grego01
Grego01 committed Jun 11, 2025
commit af592d2ba198212fea9930eec4bc14e4666b4ee8
5 changes: 5 additions & 0 deletions openmc/tallies.py
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ class Tally(IDManagerMixin):
Whether the tally will accumulate sum third and sum fourth for each tally bin
normality_tests = None
Whether normality tests will be performed on the tally results
figure_of_merit : numpy.ndarray
An array containing the figure of merit for each bin

.. versionadded:: 0.15.3
derived : bool
Whether or not the tally is derived from one or more other tallies
sparse : bool
Expand Down Expand Up @@ -142,6 +146,7 @@ def __init__(self, tally_id=None, name=''):
self._std_dev = None
self._vov = None
self._normality_tests = None
self._simulation_time = None
self._with_batch_statistics = False
self._derived = False
self._sparse = False
Expand Down
1 change: 1 addition & 0 deletions tests/unit_tests/test_tallies.py
Comment thread
Grego01-biot marked this conversation as resolved.
Resolved
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import numpy as np
import pytest
import openmc


Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.