Repository navigation
fixing expansion of elemental Ta bug - #3443
Merged
Merged
Conversation
GuySten
marked this pull request as draft
June 15, 2025 04:50
GuySten
marked this pull request as ready for review
June 15, 2025 05:08
Contributor
Author
|
This pull request works. One of the tests just timed out. |
Member
|
Just to mention we spotted something in the some depletion V&V that also suggests something was wrong with the Ta element. Depletion of Ta was giving rather different results to FISPACT. https://jbae11.github.io/openmc_activator/docs/Ta.html @jbae11 are the chain files influenced by this PR as I think we are using openmc with this bug fixed elsewhere in the workflow |
5 tasks done
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr expand the element Ta correctly.
The expansion is dependent on the nuclear data available.
Ta180_m1 is converted to Ta180 if Ta180_m1 is missing from data.
If Ta180 is also missing it is converted to Ta181
Fixes #3382
Checklist