Repository navigation
update units for flux - #3441
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the flux units in the documentation to use 1/(cm² s) consistently. The key changes include removal of the note about steady state flux units in the random ray solver and standardization of the flux unit across the documentation.
Comments suppressed due to low confidence (1)
docs/source/methods/random_ray.rst:112
- The updated documentation now consistently uses 1/(cm² s) for flux units by removing the steady state explanation. Please ensure the accompanying text clearly states whether this change reflects an update in the underlying solver's behavior or is solely a documentation revision.
:math:`1/(\text{cm}^{2} \text{s})`
jtramm
approved these changes
Jun 12, 2025
jtramm
left a comment
jtramm
left a comment
Contributor
There was a problem hiding this comment.
Thanks @aprilnovak for correcting the units here (and for taking the time to convince me of my folly!).
jtramm
enabled auto-merge (squash)
June 12, 2025 15:15
yardasol
pushed a commit
to yardasol/openmc
that referenced
this pull request
Dec 25, 2025
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3440