Repository navigation
Add methods on Material class for waste disposal rating / classification - #3366
Conversation
|
I should also add -- thanks to @eepeterson for sharing an initial version of a waste classification function based on the NRC regs 🙏 |
|
Suggestion: change the Fetter version to be one that takes a dictionary of limits and returns the waste disposal ratio. There is some history of exploring different limits using this same model for different purposes. The Fetter limits can included as a dictionary available to all users. ALARA includes a few different limits: https://github.com/svalinn/ALARA/tree/main/data |
eepeterson
left a comment
eepeterson
left a comment
There was a problem hiding this comment.
Thanks for putting this together so quickly @paulromano. Just a few small comments initially.
|
Thanks @gonuke and @eepeterson for the reviews! Your comments have been addressed in the latest commit. |
paulromano
changed the title
gonuke
left a comment
gonuke
left a comment
There was a problem hiding this comment.
This looks good to me, but just one question on whether there are existing time constants.
|
@eepeterson Any further requests for changes or is this good to go? |
eepeterson
left a comment
eepeterson
left a comment
There was a problem hiding this comment.
tiny typo but otherwise good to go
|
Is it worth adding other classification systems? Perhaps the IAEA limits could be used but I notice they are not as detailed as these ones you have used. |
|
Just wondering as this PR adds units of Ci and Ci/m3 to the get_activity. All the tests added are using get_activity with Ci/m3 Would it be worth adding one test with Ci units get_activity('Ci') |
Seems like a good follow-on PR to me... |
|
@jon-proximafusion I just added tests for Ci and Ci/m3 units. As far as the IAEA guidance, I agree with @gonuke that it would make a nice follow on PR. fwiw, I did skim through it but it wasn't immediately obvious to me where the limits are. |
|
Yes agreed on the potential follow up PR. I can perhaps do that one. I just remember how we added dose coffiecients and then needed more libraries and we had to restructure the code to allow that. I think this is another feature that is likely to have additional waste definitions desired. Perhaps the french one for ITER would be nice. Follow up PR is good with me. |
eepeterson
left a comment
eepeterson
left a comment
There was a problem hiding this comment.
Sorry for the delay, just needed a few minutes to sit down and double check all the limits. Only one correction.
Co-authored-by: Ethan Peterson <eepeterson3@gmail.com>
eepeterson
left a comment
eepeterson
left a comment
There was a problem hiding this comment.
LGTM - will merge when CI finishes
…ion (openmc-dev#3366) Co-authored-by: Ethan Peterson <eepeterson3@gmail.com>
Description
This PR adds
waste_disposal_ratingandwaste_classificationmethods on theMaterialclass that will provide the waste disposal rating (numeric value to be compared to 1.0) and the waste classification of a material based on the procedure and activity limits outlined in NRC regulations (10 CFR 61.55), respectively. Because the NRC regulations are missing many long-lived radionuclides that can be produced from fusion systems, for these applications there is a separate set of specific activity limits that have been recommended in a 1990 paper by Fetter et al.. A recent paper by Laila El-Guebaly mentions that the Fetter limits have been approved by the US Fusion Safety Standing Committee and recommends evaluating waste classification using both the NRC limits and Fetter limits. While thewaste_classificationmethod is specific to NRC regulations, you can use thewaste_disposal_ratingmethod to compute a rating for a material based on the Fetter limits. Thewaste_disposal_ratingfunction also allows a user to pass a dictionary of specific activity limits in case there are other limits they want to use.I should also note that I've added new option in the
get_activitymethod to use units of Ci or Ci/m³ since the NRC regulations use limits in units of Ci/m³.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)