Repository navigation
Fix Tabular.from_xml_element for histogram case - #3287
Merged
Merged
Conversation
pshriwise
approved these changes
Jan 31, 2025
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Thanks @paulromano! I like that the slicing is more explicit now. And thanks for addressing the XML parsing as well.
pshriwise
added
the
Merging Soon
ahnaf-tahmid-chowdhury
pushed a commit
to ahnaf-tahmid-chowdhury/OpenMC
that referenced
this pull request
Feb 6, 2025
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the change in #2981, I found that
Tabular.from_xml_elementdidn't work for the case when len(x) == len(p) + 1. This PR fixes that.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)