Repository navigation
fix the bug in function differentiate_mats() - #3277
Merged
Merged
Conversation
paulromano
enabled auto-merge (squash)
January 28, 2025 05:26
pshriwise
reviewed
Jan 29, 2025
| if diff_volume_method == 'match cell': | ||
| if cell.fill_type == 'distribmat': | ||
| for clone_mat in cell.fill: | ||
| clone_mat.volume = cell.volume |
Contributor
There was a problem hiding this comment.
Kinda late to the party here, but should the volume assigned to the material be divided by the number of cell instances in this line? Am I missing something?
Contributor
|
Cross-referencing #3132 here as it's related. |
ahnaf-tahmid-chowdhury
pushed a commit
to ahnaf-tahmid-chowdhury/OpenMC
that referenced
this pull request
Feb 6, 2025
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found that differentiate_mats method cannot assign the distributed material properly. When I use the ‘match cell’ method, only one material rather than a list is assigned to the repeating cell. That’s seem to be a bug.
Now it has been fix in this pr.
Checklist