Skip to content

add continue feature for depletion #3272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulromano merged 17 commits into from
Mar 6, 2025
Merged

add continue feature for depletion #3272

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1730c21
add continue feature for depletion and test new code
lewisgross1296 Jan 22, 2025
5ed5a59
added flags to SIIntegrator, convereted np.equal to np.array_equal, u…
lewisgross1296 Jan 28, 2025
48f8478
implement get_source_rates
lewisgross1296 Jan 28, 2025
136289c
split failure cases into two tests and added match param
lewisgross1296 Jan 28, 2025
46ab8b4
source_rate does not have index (scalar variable)
lewisgross1296 Jan 28, 2025
4fdf333
fix off by 1
lewisgross1296 Feb 19, 2025
3f96f1a
split checks, need to compute dts, need timestep_units in get_times call
lewisgross1296 Feb 19, 2025
f3358e4
make sure that continue runs with no previous results do not break
lewisgross1296 Feb 24, 2025
09df7c1
fix indent issue, add some description
lewisgross1296 Mar 4, 2025
020aff2
addressing some of Patrick's feedback
lewisgross1296 Mar 4, 2025
00e575d
remove comment in favor of docstring
lewisgross1296 Mar 4, 2025
220f1a9
imrove docstring
lewisgross1296 Mar 4, 2025
1915e6d
move completed_source_rates declaration after success of timestep check
Mar 5, 2025
384e99c
Style changes to test file
pshriwise Mar 5, 2025
471e5b6
Revert change to pugixml submodule
paulromano Mar 5, 2025
b27c9df
Small stylistic fixes
paulromano Mar 5, 2025
e2d0ad1
Simplify tests for continue run
paulromano Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix off by 1
  • Loading branch information
@lewisgross1296
lewisgross1296 committed Mar 4, 2025
commit 4fdf333f2b26649daffe133e07e23e3108da1d9f
4 changes: 2 additions & 2 deletions openmc/deplete/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,8 +477,8 @@ def get_source_rates(self) -> np.ndarray:
source_rates = np.fromiter(
(r.source_rate for r in self),
dtype=self[0].source_rate.dtype,
count=len(self),
)
count=len(self)-1,
) # Results duplicates the final source rate at the final simulation time

@pshriwise pshriwise Mar 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this comment above the code.

Suggested change
) # Results duplicates the final source rate at the final simulation time
) # Results duplicate the final source rate at the final simulation time


return source_rates
Comment on lines +466 to +485

@lewisgross1296 lewisgross1296 Feb 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like when I print out the result of this function, it duplicates the final source rate (no matter the integrator chosen). When I change to count=len(self) -1, it prints what I would expect for the source_rates ndarray.

Thinking about this more, it kind of makes sense since get_times() returns an ndarray containing 0 as the first element. If there are N timesteps and N source rates given to the integrator, then in this case, count = len(self) -1 is the correct choice for this function.

Not sure if this is intended, but the final simulation "time" duplicates the system final source rate.


Expand Down