Skip to content

Bug fix for Polygon 'yz' basis - #3259

Merged
paulromano merged 1 commit into
openmc-dev:developfrom
eepeterson:polygon_plane_fix
Jan 10, 2025
Merged

paulromano merged 1 commit into
openmc-dev:developfrom
eepeterson:polygon_plane_fix

Conversation

@eepeterson

@eepeterson eepeterson commented Jan 10, 2025 •

Copy link
Copy Markdown
Contributor

Description

The general plane constructor defaults to an x-plane with a=1. This was overlooked in the case when the Polygon basis is 'yz' and results in the wrong equation for planes in that case. This PR simply explicitly sets all kwargs in the constructor to avoid this.

Fixes # (issue)
A user raised this issue on the discourse forum here: https://openmc.discourse.group/t/polygon-yz-basis-bug/5124

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the expedient fix @eepeterson

@paulromano
paulromano enabled auto-merge (squash) January 10, 2025 19:42
@paulromano
paulromano merged commit c226c78 into openmc-dev:develop Jan 10, 2025
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants