Repository navigation
Bug fix for Polygon 'yz' basis - #3259
Merged
Merged
Conversation
paulromano
approved these changes
Jan 10, 2025
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the expedient fix @eepeterson
paulromano
enabled auto-merge (squash)
January 10, 2025 19:42
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The general plane constructor defaults to an x-plane with
a=1. This was overlooked in the case when the Polygon basis is 'yz' and results in the wrong equation for planes in that case. This PR simply explicitly sets all kwargs in the constructor to avoid this.Fixes # (issue)
A user raised this issue on the discourse forum here: https://openmc.discourse.group/t/polygon-yz-basis-bug/5124
Checklist