Repository navigation
Ensure libMesh::ReplicatedMesh is used for LibMesh tallies - #3208
Merged
Merged
Conversation
paulromano
approved these changes
Dec 3, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @nuclearkevin!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a quick check in
LibMesh::LibMesh(libMesh::MeshBase& input_mesh ...)to ensure that theinput_meshpoints to alibMesh::ReplicatedMeshinstance, alongside explicitly instantiating alibMesh::ReplicatedMeshinLibMesh::set_mesh_pointer_from_filename(...)(suggested by @pshriwise while discussing #3206). This enforces the currently assumed behaviour that the entire mesh exists on all MPI ranks.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)