Repository navigation
add export_model_xml arguments to Model.plot_geometry and Model.calculate_volumes - #3190
Merged
Merged
Conversation
paulromano
approved these changes
Nov 9, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks @nplinden! I made one small update to ensure that if you pass path='other_name.xml', it gets passed to plot_geomtery and calculate_volumes accordingly.
paulromano
enabled auto-merge (squash)
November 9, 2024 17:05
magnoxemo
pushed a commit
to magnoxemo/openmc
that referenced
this pull request
Nov 22, 2024
…late_volumes (openmc-dev#3190) Co-authored-by: Nicolas Linden <n.linde@naarea.fr> Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…late_volumes (openmc-dev#3190) Co-authored-by: Nicolas Linden <n.linde@naarea.fr> Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an
export_model_xmlargument toModel.plot_geometryandModel.calculate_volumes, for coherence with theModel.runmethod.The implementation mimics that of
Model.runand the new argument defaults to True.Previously running these methods in the same script resulted in populating the working directory with model.xml as well as the geometry/materials/settings/plots/tallies.xml, making things ambiguous.
Checklist