Repository navigation
Update surface_composite.py - #3189
Merged
paulromano merged 1 commit intoNov 9, 2024
Merged
paulromano merged 1 commit into
paulromano merged 1 commit into
Conversation
enable inplace
Member
|
Nice, is it worth adding a test for this to prevent the bug returning |
Contributor
Author
@shimwell should I create a separate PR with the test? I haven’t had a chance to write it yet, but I can work on it next week. |
magnoxemo
pushed a commit
to magnoxemo/openmc
that referenced
this pull request
Nov 22, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is a bug fix. I changed the line for the rotation of composite surfaces to enable inplace rotation. I copy pasted the line from
translatefor which inplace works fine.Checklist