Skip to content

Support rotation in MeshFilter #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pshriwise merged 23 commits into from
Dec 20, 2025
Merged

Support rotation in MeshFilter #3176

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d3b9dde
rotation variable added
zoeprieto Oct 11, 2024
09d9a2d
rotation implemented
zoeprieto Oct 11, 2024
2fc5b47
rotation mesh filter as cell rotation
zoeprieto Oct 14, 2024
3afb6d5
position.h added
zoeprieto Oct 14, 2024
1c07c34
clean changes
zoeprieto Oct 15, 2024
bb27cd0
format fix
zoeprieto Oct 15, 2024
5c3b2cb
function deleted
zoeprieto Oct 15, 2024
32e129b
fix mesh rotation
zoeprieto Oct 16, 2024
be3151a
add test
zoeprieto Oct 17, 2024
ee13f82
update tests
zoeprieto Oct 17, 2024
a819151
update test
zoeprieto Oct 17, 2024
f8bd1e4
update test
zoeprieto Oct 17, 2024
7280d8c
update test
zoeprieto Oct 18, 2024
1e4bb8b
Update openmc/filter.py
zoeprieto May 29, 2025
342cfaf
Adding fix for roundtrip of 3 angles for rotation and test
pshriwise Jun 1, 2025
6c92956
Apply inverse rotation instead of rotation for MeshFilter
pshriwise Jun 1, 2025
4f73918
Updating results for a non-symmetric rotation angle
pshriwise Jun 1, 2025
da17908
Merge branch 'develop' into MeshRotation
pshriwise Dec 16, 2025
e3ee7a4
Updating test input to comply with new XML attribute ordering expecta…
pshriwise Dec 16, 2025
5fd92e4
Update results_true.dat
zoeprieto Dec 16, 2025
a69934e
Reverting change to application of mesh rotation
pshriwise Dec 18, 2025
e5b12c2
Expanding comment on rotation_ attribute for mesh fitlers and cells.
pshriwise Dec 18, 2025
bc4128e
Updating results after revert of 6c925963f
pshriwise Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updating results for a non-symmetric rotation angle
  • Loading branch information
@pshriwise
pshriwise committed Jun 1, 2025
commit 4f739184a9574f8fc23711a91abb20d77448b1de
2 changes: 1 addition & 1 deletion tests/regression_tests/filter_rotations/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
<filter id="1" type="mesh">
<bins>1</bins>
</filter>
<filter id="2" rotation="180 0 0" type="mesh">
<filter id="2" rotation="0 0 10" type="mesh">
<bins>2</bins>
</filter>
<tally id="1">
Expand Down
240 changes: 120 additions & 120 deletions tests/regression_tests/filter_rotations/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,123 +122,123 @@ tally 1:
4.344414E-02
3.825354E-04
tally 2:
4.852204E-02
4.919417E-04
7.229090E-02
1.062894E-03
4.344414E-02
3.825354E-04
1.438711E-01
4.191824E-03
3.276170E-01
2.210924E-02
1.279501E-01
3.435254E-03
1.356118E-01
3.711749E-03
3.400140E-01
2.367518E-02
1.385305E-01
4.060592E-03
4.951220E-02
4.952385E-04
7.401227E-02
1.124154E-03
5.151090E-02
5.339359E-04
6.083700E-02
7.861240E-04
9.978991E-02
2.022733E-03
6.004653E-02
7.428556E-04
1.827950E-01
6.839560E-03
5.780661E-01
6.799910E-02
1.881215E-01
7.093746E-03
1.978591E-01
7.894161E-03
5.162186E-01
5.357742E-02
1.897326E-01
7.231935E-03
6.355178E-02
8.423316E-04
1.040915E-01
2.224064E-03
6.902234E-02
9.843766E-04
7.502684E-02
1.208304E-03
1.244515E-01
3.168682E-03
7.515812E-02
1.151397E-03
2.370758E-01
1.150628E-02
9.973982E-01
2.489516E-01
2.152505E-01
9.424546E-03
2.153323E-01
9.293477E-03
9.414362E-01
2.261845E-01
2.016933E-01
8.270477E-03
7.356007E-02
1.090617E-03
1.161258E-01
2.734941E-03
6.745417E-02
9.371031E-04
7.633486E-02
1.216488E-03
1.117747E-01
2.538705E-03
7.438042E-02
1.127109E-03
2.114692E-01
9.202185E-03
6.514433E-01
8.523087E-02
1.905740E-01
7.287607E-03
1.891692E-01
7.211874E-03
5.976566E-01
7.206211E-02
1.805640E-01
6.599680E-03
6.674847E-02
9.080853E-04
9.747628E-02
1.934325E-03
6.824062E-02
9.908844E-04
5.568294E-02
6.368003E-04
6.775790E-02
9.447074E-04
5.580909E-02
6.303584E-04
1.646205E-01
5.916595E-03
3.806765E-01
2.947576E-02
1.470573E-01
4.360385E-03
1.272758E-01
3.371623E-03
3.599375E-01
2.655645E-02
1.377572E-01
3.835778E-03
4.880089E-02
4.894233E-04
8.221192E-02
1.373712E-03
5.205261E-02
5.584673E-04
4.979685E-02
5.000651E-04
8.904798E-02
1.599985E-03
4.263510E-02
3.790580E-04
1.143827E-01
2.728168E-03
3.625668E-01
2.694130E-02
1.498504E-01
4.528028E-03
1.854298E-01
7.395316E-03
3.754755E-01
2.863730E-02
1.299779E-01
3.413506E-03
4.570813E-02
4.237320E-04
7.078666E-02
1.024725E-03
6.199337E-02
7.693332E-04
7.430536E-02
1.124804E-03
1.049402E-01
2.235460E-03
5.278717E-02
5.679966E-04
1.776084E-01
6.392262E-03
5.922459E-01
7.064506E-02
1.964537E-01
7.878531E-03
2.360406E-01
1.151997E-02
6.474676E-01
8.421908E-02
1.775375E-01
6.335831E-03
6.473004E-02
8.708812E-04
1.082380E-01
2.366483E-03
7.925621E-02
1.274592E-03
8.053214E-02
1.304602E-03
1.231504E-01
3.091119E-03
6.168272E-02
7.794018E-04
1.950378E-01
7.627979E-03
9.349517E-01
2.219668E-01
2.139229E-01
9.331947E-03
2.536734E-01
1.322855E-02
1.008102E+00
2.572272E-01
1.940280E-01
7.583659E-03
6.313552E-02
8.566804E-04
1.267125E-01
3.258418E-03
7.935968E-02
1.287807E-03
6.591701E-02
8.937559E-04
1.075008E-01
2.379510E-03
5.854402E-02
6.904933E-04
1.836732E-01
6.774629E-03
5.137703E-01
5.309022E-02
2.012342E-01
8.159391E-03
2.002177E-01
8.203771E-03
5.799525E-01
6.821961E-02
1.838319E-01
6.790721E-03
5.025368E-02
5.252196E-04
1.006049E-01
2.051529E-03
6.289880E-02
8.084952E-04
5.545799E-02
6.215743E-04
8.006280E-02
1.303253E-03
4.526184E-02
4.117601E-04
1.242037E-01
3.155145E-03
3.383169E-01
2.334568E-02
1.520166E-01
4.862270E-03
1.505665E-01
4.578798E-03
3.273729E-01
2.206907E-02
1.186196E-01
2.909780E-03
4.249449E-02
3.698278E-04
7.572513E-02
1.180964E-03
4.574059E-02
4.260433E-04
3 changes: 1 addition & 2 deletions tests/regression_tests/filter_rotations/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def model():
model.settings.inactive = 0
model.settings.particles = 1000

rotation = np.array((180, 0, 0))
rotation = np.array((0, 0, 10))

llc = np.array([-9, -9, -9])
urc = np.array([9, 9, 9])
Expand All @@ -48,7 +48,6 @@ def model():

filters.append(openmc.MeshFilter(reg_mesh))


# rotated meshes
rotated_reg_mesh = openmc.RegularMesh()
rotated_reg_mesh.dimension = mesh_dims
Expand Down