Skip to content

Move to support python 3.13 - #3165

Merged
paulromano merged 6 commits into
openmc-dev:developfrom
MicahGale:py313
Jan 8, 2025
Merged

paulromano merged 6 commits into
openmc-dev:developfrom
MicahGale:py313

Conversation

@MicahGale

@MicahGale MicahGale commented Oct 8, 2024 •

Copy link
Copy Markdown
Contributor

Description

This is a quick update to pyproject.toml and the CI test suite to ratchet the supported versions of python to include 3.11 - 3.13

Fixes #3164.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale
MicahGale marked this pull request as draft October 8, 2024 16:03
@MicahGale

Copy link
Copy Markdown
Contributor Author

This is currently limited by vtk not supporting Python 3.13. Here is the issue tracking this: https://gitlab.kitware.com/vtk/vtk/-/issues/19489

@MicahGale

Copy link
Copy Markdown
Contributor Author

It looks like VTK now ships 3.13. @pshriwise or @paulromano, could you trigger GHA to rerun?

@paulromano

Copy link
Copy Markdown
Contributor

Still failing as there are no Python 3.13 wheels on PyPI

@MicahGale

Copy link
Copy Markdown
Contributor Author

My bad. I misinterpreted what had happened in the VTK repo.

@MicahGale

MicahGale commented Nov 9, 2024 •

Copy link
Copy Markdown
Contributor Author

Update. VTK is being held back by mpi4py. mipy4py 4.x does support 3.13, but they are pinned to version 3.x, which has no plans to support 3.13. So until they are able to migrate to the next release of mpi4py, which will be non-trivial, this upgrade is blocked.

The changes have been made, but are not currently planned to be incorporated into the next release yet.

@MicahGale
MicahGale marked this pull request as ready for review December 3, 2024 04:11
@MicahGale

Copy link
Copy Markdown
Contributor Author

@paulromano or @pshriwise. I think this is ready for review. It's not showing as completed as a lot of the required jobs are for python 3.10 which technically shouldn't be supported anymore. I'd suggest moving these to python 3.11 or 3.13.

@shimwell

Copy link
Copy Markdown
Member

Just noticed this conda forge PR that was automatically created. Perhaps of interest as it attempts to build the conda package for 3.13
conda-forge/openmc-feedstock#75

@MicahGale

Copy link
Copy Markdown
Contributor Author

Quickly looking into that it looks like Conda is search for a release candidate for Py 3.13 and Numpy 2.x. I'm not sure exactly why it's doing that, but this would be for 0.15.0 that it is attempting. I'm thinking of just letting that fail and add py 3.13 to the next release.

@paulromano
paulromano merged commit 10a63bb into openmc-dev:develop Jan 8, 2025
@MicahGale

Copy link
Copy Markdown
Contributor Author

Thanks @paulromano!

apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Python 3.13

3 participants