Repository navigation
[docs] theory on PCG random number generator - #3134
Merged
Merged
Conversation
added 10 commits
September 17, 2024 00:51
rzehumat
commented
Sep 18, 2024
rzehumat
commented
Sep 18, 2024
rzehumat
commented
Sep 18, 2024
rzehumat
commented
Sep 18, 2024
rzehumat
marked this pull request as ready for review
September 18, 2024 16:17
paulromano
approved these changes
Oct 3, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
@rzehumat Thanks a lot for this contribution! I ended up simplifying a lot of what was written here by explaining the basic concepts but leaving the details to other references. If someone really wants to know how it works, they are probably better served by reading the original reports or by looking through the source code.
paulromano
enabled auto-merge (squash)
October 3, 2024 21:18
Contributor
Author
|
Hi @paulromano , thanks for your review and edit. I agree my original explanation was messy so keeping it short and simple would be the best option. Furthermore, the referenced paper by M. O'Neill is open and - in my opinion - really well written. |
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Matej Rzehulka <matej.rzehulka@suro.cz> Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2486 - it contains
random_lcg.cpp- might be reverted, as this change is technically not releavant to the issueFixes #2486
Checklist
This is my first pull request to OpenMC. Sorry in advance for any errors.