Repository navigation
adapt the openmc-update-inputs script for surfaces - #3131
Merged
Merged
Conversation
paulromano
approved these changes
Oct 3, 2024
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rayanhaddad169! Also a reminder to me that I should get those models updated on the benchmarks repo 🤔
paulromano
enabled auto-merge (squash)
October 3, 2024 19:45
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: r.haddad <r.haddad@naarea.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've been working on the benchmarks from the MIT CRPG repository, and I've encountered some geometry.xml files (e.g., example) that are still using the old format. In this format, surface elements contain child tags rather than attributes, which prevents them from being loaded directly using the OpenMC Python API.
To address this, I have updated the openmc-update-inputs to accommodate these changes and ensure compatibility with the newer format.
Fixes # (issue)
Checklist