Skip to content

adapt the openmc-update-inputs script for surfaces - #3131

Merged
paulromano merged 4 commits into
openmc-dev:developfrom
rayanhaddad169:omc_update_script
Oct 3, 2024
Merged

paulromano merged 4 commits into
openmc-dev:developfrom
rayanhaddad169:omc_update_script

Conversation

@rayanhaddad169

@rayanhaddad169 rayanhaddad169 commented Sep 9, 2024 •

Copy link
Copy Markdown
Contributor

Description

I've been working on the benchmarks from the MIT CRPG repository, and I've encountered some geometry.xml files (e.g., example) that are still using the old format. In this format, surface elements contain child tags rather than attributes, which prevents them from being loaded directly using the OpenMC Python API.

To address this, I have updated the openmc-update-inputs to accommodate these changes and ensure compatibility with the newer format.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rayanhaddad169! Also a reminder to me that I should get those models updated on the benchmarks repo 🤔

@paulromano
paulromano enabled auto-merge (squash) October 3, 2024 19:45
@paulromano
paulromano merged commit 3a5b218 into openmc-dev:develop Oct 3, 2024
@rayanhaddad169
rayanhaddad169 deleted the omc_update_script branch October 28, 2024 14:21
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Co-authored-by: r.haddad <r.haddad@naarea.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants