Repository navigation
abort on cmake config if openmp requested but not found - #2893
Merged
Merged
Conversation
paulromano
approved these changes
Mar 6, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Agreed — if OPENMC_USE_OPENMP is enabled, it shouldn't let it slide if OpenMP is not found. Thanks!
paulromano
enabled auto-merge (squash)
March 6, 2024 03:43
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We should not let CMake silently fail if CMake can't find OpenMP. Currently, the CMake flags for OpenMP can be set, but if it's not available on the system (a rarity but for Macs by default it seems!) the configuration proceeds anyway. I found it strange that this fancy Apple silicon was lagging, and of course observing the output header, no thread count info was provided!
This is an unexpected failure with a one-line fix. If a user wishes to not use OpenMP, it should be reflected in the CMake configuration flags.
Checklist