Skip to content

Storing surface source points using a cell ID #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gridley merged 51 commits into from
Jun 19, 2024
Merged

Storing surface source points using a cell ID #2888

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
e0c07ac
New 'surface source write' features
JoffreyDorville Jan 5, 2024
f4d69bd
Add TODO
JoffreyDorville Mar 1, 2024
47ad268
Run test in tmp dir
JoffreyDorville Mar 1, 2024
0810227
Cleaning
JoffreyDorville Mar 1, 2024
3975d91
Update results generated before PR2811
JoffreyDorville Mar 1, 2024
ff7fa35
Cleaning
JoffreyDorville Mar 1, 2024
52ef531
Run regression tests on 1 MPI process
JoffreyDorville Mar 4, 2024
2a1ac56
Safer handling of env variables and config dict
JoffreyDorville Mar 4, 2024
225b8eb
Dedicated cases for event-based mode
JoffreyDorville Mar 5, 2024
230447d
Enable surf_source_write for DAGMC
JoffreyDorville Mar 6, 2024
4f8e700
Cleaning
JoffreyDorville Mar 6, 2024
78f412c
Unit test for DAGMC cases
JoffreyDorville Mar 8, 2024
be6154c
Regression test for DAGMC cases
JoffreyDorville Mar 8, 2024
adab1fc
Cleaning
JoffreyDorville Mar 8, 2024
1ca0df4
Proofreading comments
JoffreyDorville Mar 8, 2024
1ca7ec1
Updates from review of PR 2888
paulromano Mar 18, 2024
8725fe3
Update inputs_true.dat for ssw case-2
paulromano Mar 19, 2024
bd0fa52
Update ssw test_exceptions
paulromano Mar 19, 2024
310408c
Update regression tests input to match the rpp declaration
JoffreyDorville Jun 5, 2024
4f7bfde
Change surface ID for comparison with rpp
JoffreyDorville Jun 7, 2024
0140272
Updated test results for rpp geometry
JoffreyDorville Jun 7, 2024
d604802
Remove identical dagmc.h5m file
JoffreyDorville Jun 7, 2024
39af2cb
Cleaning
JoffreyDorville Jun 7, 2024
368c43a
Simplification
JoffreyDorville Jun 7, 2024
3c9352a
Cleaning
JoffreyDorville Jun 7, 2024
fcfd530
Remove identical dagmc.h5m file
JoffreyDorville Jun 7, 2024
23a60af
Cleaning
JoffreyDorville Jun 7, 2024
c62e72e
Cleaning
JoffreyDorville Jun 7, 2024
4a1d43a
Pass const ref surface to cross_surface() to share with add_surf_sour…
JoffreyDorville Jun 10, 2024
88993a5
Use the surface to check for vacuum boundary conditions
JoffreyDorville Jun 10, 2024
5b4cbe3
Store surface source points after cross_surface()
JoffreyDorville Jun 10, 2024
023d7e1
Change material definition of uranium to avoid last digit difference …
JoffreyDorville Jun 10, 2024
7681bdc
Updating test results
JoffreyDorville Jun 10, 2024
92d44f7
Store particle in surface source before or after crossing surface
JoffreyDorville Jun 10, 2024
e167bc6
Adding test case for periodic boundary conditions
JoffreyDorville Jun 10, 2024
8e6edec
Rename regression test cases
JoffreyDorville Jun 11, 2024
a4c3851
Documentation update for the periodic BC test cases
JoffreyDorville Jun 11, 2024
ebf9409
Rename additional test case
JoffreyDorville Jun 11, 2024
9322e9c
Rename event based test cases
JoffreyDorville Jun 11, 2024
fe3cfe5
Rename DAGMC test cases
JoffreyDorville Jun 11, 2024
d1d021c
Rename test cases for periodic BC
JoffreyDorville Jun 11, 2024
b784363
Correct path for case-01 to case-09
JoffreyDorville Jun 11, 2024
82bf2cd
Reduce number of stored particle to optimize memory use
JoffreyDorville Jun 11, 2024
214eb70
Update regression tests results
JoffreyDorville Jun 11, 2024
fb1894a
Reduce number of particles in simulation of regression tests
JoffreyDorville Jun 11, 2024
7fa51ea
Update regression tests results
JoffreyDorville Jun 11, 2024
ecf45da
Increase the number of points generated in case-a01
JoffreyDorville Jun 11, 2024
6054bb2
Cleaning
JoffreyDorville Jun 11, 2024
73d7a1d
Check surf_source_ before calling add_surf_source_to_bank
paulromano Jun 13, 2024
18b3be8
Logic change in add_surf_source_to_bank
paulromano Jun 13, 2024
534e9f5
Style updates, remove only_fissionable
paulromano Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regression test for DAGMC cases
  • Loading branch information
@JoffreyDorville
JoffreyDorville committed Mar 8, 2024
commit be6154c32c7fd39adef68bc1febec7f5c609cb98
33 changes: 33 additions & 0 deletions tests/regression_tests/surface_source_write/case-24/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<max_particles>300</max_particles>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-24/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-24/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
34 changes: 34 additions & 0 deletions tests/regression_tests/surface_source_write/case-25/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<surface_ids>1</surface_ids>
<max_particles>300</max_particles>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-25/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-25/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
34 changes: 34 additions & 0 deletions tests/regression_tests/surface_source_write/case-26/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<max_particles>300</max_particles>
<cell>2</cell>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-26/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-26/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
35 changes: 35 additions & 0 deletions tests/regression_tests/surface_source_write/case-27/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<surface_ids>1</surface_ids>
<max_particles>300</max_particles>
<cell>2</cell>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-27/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-27/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
34 changes: 34 additions & 0 deletions tests/regression_tests/surface_source_write/case-28/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<max_particles>300</max_particles>
<cellfrom>2</cellfrom>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-28/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-28/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
34 changes: 34 additions & 0 deletions tests/regression_tests/surface_source_write/case-29/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<max_particles>300</max_particles>
<cellto>2</cellto>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-29/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.263843E-01 3.193920E-02
Binary file added tests/regression_tests/surface_source_write/case-29/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
49 changes: 49 additions & 0 deletions tests/regression_tests/surface_source_write/case-30/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<cell fill="1" id="8" region="101 -102 103 -104 105 -106" universe="2"/>
<cell id="9" material="41" region="107 -108 109 -110 111 -112 (-101 | 102 | -103 | 104 | -105 | 106)" universe="2"/>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
<surface coeffs="-22.0" id="101" type="z-plane"/>
<surface coeffs="22.0" id="102" type="z-plane"/>
<surface coeffs="-22.0" id="103" type="x-plane"/>
<surface coeffs="22.0" id="104" type="x-plane"/>
<surface coeffs="-22.0" id="105" type="y-plane"/>
<surface coeffs="22.0" id="106" type="y-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="107" type="z-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="108" type="z-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="109" type="x-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="110" type="x-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="111" type="y-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="112" type="y-plane"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<surface_ids>101 102 103 104 105 106</surface_ids>
<max_particles>300</max_particles>
<cell>7</cell>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-30/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.756086E-01 4.639209E-02
Binary file added tests/regression_tests/surface_source_write/case-30/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
49 changes: 49 additions & 0 deletions tests/regression_tests/surface_source_write/case-31/inputs_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?xml version='1.0' encoding='utf-8'?>
<model>
<materials>
<material depletable="true" id="40" name="no-void fuel">
<density units="g/cc" value="11"/>
<nuclide ao="1.0" name="U235"/>
</material>
<material id="41" name="water">
<density units="g/cc" value="1.0"/>
<nuclide ao="2.0" name="H1"/>
<nuclide ao="1.0" name="O16"/>
<sab name="c_H_in_H2O"/>
</material>
</materials>
<geometry>
<cell fill="1" id="8" region="101 -102 103 -104 105 -106" universe="2"/>
<cell id="9" material="41" region="107 -108 109 -110 111 -112 (-101 | 102 | -103 | 104 | -105 | 106)" universe="2"/>
<dagmc_universe filename="../dagmc.h5m" id="1"/>
<surface coeffs="-22.0" id="101" type="z-plane"/>
<surface coeffs="22.0" id="102" type="z-plane"/>
<surface coeffs="-22.0" id="103" type="x-plane"/>
<surface coeffs="22.0" id="104" type="x-plane"/>
<surface coeffs="-22.0" id="105" type="y-plane"/>
<surface coeffs="22.0" id="106" type="y-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="107" type="z-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="108" type="z-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="109" type="x-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="110" type="x-plane"/>
<surface boundary="vacuum" coeffs="-24.0" id="111" type="y-plane"/>
<surface boundary="vacuum" coeffs="24.0" id="112" type="y-plane"/>
</geometry>
<settings>
<run_mode>eigenvalue</run_mode>
<particles>100</particles>
<batches>5</batches>
<inactive>1</inactive>
<source particle="neutron" strength="1.0" type="independent">
<space type="fission">
<parameters>-4 -4 -20 4 4 20</parameters>
</space>
</source>
<surf_source_write>
<surface_ids>101 102 103 104 105 106</surface_ids>
<max_particles>300</max_particles>
<cell>8</cell>
</surf_source_write>
<seed>1</seed>
</settings>
</model>
2 changes: 2 additions & 0 deletions tests/regression_tests/surface_source_write/case-31/results_true.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
k-combined:
9.756086E-01 4.639209E-02
Binary file added tests/regression_tests/surface_source_write/case-31/surface_source_true.h5
View file
Open in desktop
Binary file not shown.
Binary file added tests/regression_tests/surface_source_write/dagmc.h5m
View file
Open in desktop
Binary file not shown.
Loading