Repository navigation
added check for length of value passed into EnergyFilter - #2887
Merged
paulromano merged 1 commit intoApr 11, 2024
Merged
paulromano merged 1 commit into
paulromano merged 1 commit into
Conversation
paulromano
approved these changes
Apr 11, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the improvement!
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated put this thread on the forum where a user was able to make an EnergyFilter with a single value. In the docstring the energyfilter requires at least a pair of numbers to work.
This PR adds a check on the EnergyFilter value length to ensure it is a minimum value of 2.
Description
Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.
Fixes # (issue)
Checklist