Skip to content

Add openmc_mesh_get_volumes C API function - #2869

Merged
pshriwise merged 1 commit into
openmc-dev:developfrom
paulromano:mesh-get-volumes
Feb 13, 2024
Merged

pshriwise merged 1 commit into
openmc-dev:developfrom
paulromano:mesh-get-volumes

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

Description

This PR adds an openmc_mesh_get_volumes C API function and corresponding Python binding as the openmc.lib.Mesh.volumes property. I'm planning on using this downstream in the plotter application to be able to plot volume-normalized mesh tallies.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano
paulromano requested a review from pshriwise February 11, 2024 17:17

@pshriwise pshriwise left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @paulromano! Will merge at the end of the day if there are no other comments.

@pshriwise
pshriwise merged commit bf33a9e into openmc-dev:develop Feb 13, 2024
@paulromano
paulromano deleted the mesh-get-volumes branch February 13, 2024 15:37
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
apingegno pushed a commit to apingegno/openmc that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants