Repository navigation
Fix locating h5m files references in DAGMC universes - #2842
Merged
Merged
Conversation
paulromano
changed the title
pshriwise
approved these changes
Jan 16, 2024
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
I like the simplifications here. Thanks @paulromano!
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If you have a model.xml file with a DAGMC universe that references a .h5m file in a directory other than the directory where the model.xml file lives, you'll get a fatal error if you run
openmc model.xml. This PR fixes this behavior and does a little bit of cleanup with howsettings::path_inputis handled.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)