Repository navigation
Ensure that implicit complement cells appear last in DAGMC universes - #2838
Conversation
|
Thanks for tackling this @paulromano!! 💚 The shift in the Here in OpenMC, we could create a C++ unit test that loads one of the DAGMC files, creates a |
|
In addition to fixing the underprediction in keff that is discussed in svalinn/DAGMC#934, I'm happy to report that this also eliminates a lot of plotting artifacts that I (and others) have seen when using MOAB 5.4+. For example, here is a sample plot from the MSRE CAD model: Before this PR After this PR |
|
Confirming this makes nicer plots of the openmsr |
|
@pshriwise I just updated one of our existing DAGMC tests to check for the implicit complement cell ordering. |
pshriwise
left a comment
pshriwise
left a comment
There was a problem hiding this comment.
Looks great! Thank you @paulromano.
3 participants
Description
The bug that this fixes is described in lots of detail at svalinn/DAGMC#934. It's debatable whether this is a DAGMC or OpenMC bug, but in either case, this PR will fix the behavior. Namely, for some DAGMC models, using MOAB 5.4+ currently results in particles incorrectly being found in the implicit complement volume when they shouldn't be. The change here ensures that all other volumes are checked first.
@pshriwise I don't have a test for this because I can't think of how one would do it. Let me know if you have any ideas.
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)