Repository navigation
Fix distribcell labels for lattices used as fill in multiple cells - #2813
Merged
Merged
Conversation
paulromano
approved these changes
Apr 7, 2024
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix @pshriwise! I made one small update in the tests but otherwise looked good
paulromano
enabled auto-merge (squash)
April 7, 2024 14:55
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
…penmc-dev#2813) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
…penmc-dev#2813) Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial fix for #2798. This fixes the creation of distribcell filter bin labels for the
tallies.outfile and theDistribcellFilter::get_all_binsfor models that fill more than one cell with the same lattice. Without this change, all tally cell instance results are attributed to the set of cell instances in the first use of the lattice. I've extended thetest_cell_instances.pyto ensure that the tallies.out file is written successfully and that tally results are present for all bins in the test problem to verify that this fix is correct.Note: This fix only applies to the
RectangularLatticefurther corrections are needed forHexagonalLattice's (see #2798) for more info.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)