Repository navigation
Fix creation of meshes when from loading settings from XML - #2805
Merged
Merged
Conversation
pshriwise
approved these changes
Dec 13, 2023
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! As the changes here are pretty straightforward I won't let this sit long before merging. Thanks @paulromano
pshriwise
added
the
Merging Soon
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Right now, if you call
Model.from_xmlorModel.from_model_xmlon a model that has meshes in the<settings>element, you end up with warnings like the following:This PR fixes this by properly checking if a mesh has already been created and passed through to
Settings.from_xml_element.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)