Repository navigation
Move 'import lxml' to third-party block of imports - #2803
Merged
Merged
Conversation
shimwell
approved these changes
Dec 12, 2023
shimwell
left a comment
shimwell
left a comment
Member
There was a problem hiding this comment.
Saw this easy to review PR and gave it a speedy review. All looks good to me. I see a few other unused imports were removed as well, nice.
Member
|
Will merge tomorrow if there are no objections |
shimwell
added
the
Merging Soon
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Very simple PR here that just fixes where
import lxmlappears in Python scripts. Per PEP8, imports should be grouped in the following order: standard-library imports, third-party imports, local imports. A few unused imports have been removed while I was at it.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)