Repository navigation
Ensure that property setters are used in CylindricalMesh and SphericalMesh - #2709
Merged
Merged
Conversation
pshriwise
approved these changes
Sep 26, 2023
pshriwise
left a comment
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Thanks for these updates @paulromano. 🧇's rule.
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the constructors for
CylindricalMeshandSphericalMeshwere directly setting_r_grid,_phi_grid, etc. instead of going through the properties, which perform checks on the values. This PR fixes and makes corresponding changes in the tests.I've also included a few small fixes for warnings that were being raised during tests.
Checklist
I have run clang-format on any C++ source files (if applicable)