Repository navigation
allowing different volume methods for diff mat - #2691
Merged
paulromano merged 2 commits intoSep 26, 2023
Merged
paulromano merged 2 commits into
paulromano merged 2 commits into
Conversation
paulromano
approved these changes
Sep 25, 2023
paulromano
left a comment
paulromano
left a comment
Contributor
There was a problem hiding this comment.
If at first you don't succeed, try again 😄 I like the approach you have here. I just made a few small stylistic fixes and I think it's good to go. Thanks!
paulromano
enabled auto-merge (squash)
September 25, 2023 20:31
Member
Author
|
Thanks Paul, style is always appreciated. Glad we found a method of getting the tweak to the |
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Sep 27, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
apingegno
pushed a commit
to apingegno/openmc
that referenced
this pull request
May 7, 2026
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A while back I tried PR #2653 but this changed the behaviour of the diff_burnable_mat too much for it's main use case.
diff_burnable_matappears to be doing two things when set to True, it changes the materials volumes and makes extra materials. This PR attempts to separate out both of these things and allow the user to specify each oneThis PR is an attempt to add another argument to CoupledOperator so that the manner in which the volume is found can be user specified. This maintains current behavior as default when diff_burnable_mat is set to True but also allows users to split up the materials so that their volumes are assigned to the cell volume instead of always being divided equally.
This PR attempts to add another argument called
diff_volume_methodwhich can be set to "divide equally" (default) or "match cell" (useful for fusion r2s and burn up)Fig 6 in this fantastic paper 😄 suggests we get about 20% burn up at the front of DEMO reactor solid breeder blankets. Hence I'm keen to see the CoupledOperator working in this slightly different way for fusion simulations.
Fixes # (issue)
Checklist